refactor: make ConnectionPlan.connect_args read-only#25
Merged
Conversation
…Type Wraps the popped connect_args dict in types.MappingProxyType so the Mapping annotation is literally read-only at runtime. No behavior change (the dict was never mutated post-construction); _connect's ** unpacking works unchanged. Lightweight-lane change bundle included. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny hardening folded in from the connection-plan-split (#24) final review. No behavior change, no release intended.
ConnectionPlan.connect_argsis annotatedMapping[str, Any](read-only intent) but stored the livedict. This wraps it intypes.MappingProxyType(...)so the annotation is literally true — the seam can't be mutated through.Changes
db_retry/connections.py—import types;connect_args=types.MappingProxyType(connect_args)when building the plan._connect's**plan.connect_argsworks unchanged on aMappingProxyType.tests/test_connection_factory.py— test thatplan.connect_argsrejects mutation (TypeError).planning/changes/2026-06-27.01-connect-args-readonly/.Verification
TypeErrorafter the wrap (GREEN).just test→ 28 passed, 100% coverage (loop tests confirm**unpacking still works).just lint-ci→ clean;just check-planning→planning: OK.🤖 Generated with Claude Code